Deleting all the records in a table by Mistake using ADO.NET

Home » Advice for New Developers » C# » Deleting all the records in a table by Mistake using ADO.NET
Your Journey Starts Here on a blackboard

I was writing some ADO.NET data access code the other day and something stirred in the memory banks about a similar disaster to what I’m talking about in this post that happened years ago. I couldn’t remember exactly the circumstances of the original disaster but it prompted me to warn my team about it.

Consider the following code:

Can you spot the mistake?

If I told you that this mistake will result in all the records in the table being deleted and you look again, can you spot it?

Can you spot the mistake in this code?

The problem is the MyKey = MyKey or @MyKey = @MyKey should read MyKey = @MyKey. It just struck me that if you make a single character typo when writing this code, the end result would be to delete all the records in the table. In development shops that develop on shared test or live databases (one of my customers does, despite my continued protests), this can easily lead to disaster.

I’d be interested to know how many people spotted it on first read, especially if you weren’t previously aware of this type of thing. Our brains tend to read what we expect to see, rather than what’s actually there, for example repeating a word in a sentence isn’t always obvious for the same reason.

About Phil

I have been working as a software developer since 1983. This blog could have been called "From Fortran 77, C and Cobol to C# in 20 (not so) easy years", but it doesn't sound quite right somehow. Besides I'm talking about what's happened since 2003, not before!

Leave a Reply

Your email address will not be published.


You may use these HTML tags and attributes: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <cite> <code class="" title="" data-url=""> <del datetime=""> <em> <i> <q cite=""> <s> <strike> <strong> <pre class="" title="" data-url=""> <span class="" title="" data-url="">




Top Posts & Pages

Categories

Recent Posts

Recent Comments

Archives

Blogroll

  • Mike Cohn's Blog
  • Scott Hanselman's Blog
- lance@mountaingoatsoftware.com

Scrum Master jobs are on the rise and so are their salaries. But is everything as it seems?

- lance@mountaingoatsoftware.com

In this post I share 5 highlights from my Facebook Live session with Brian Milner.

- lance@mountaingoatsoftware.com

Today, Certified Scrum Trainer Scott Dunn shares his insights about the pain felt when leadership do

- lance@mountaingoatsoftware.com

After making one decision, it can be helpful to make the next decision or two at the same time.

- Scott Hanselman

I love the Raspberry Pi and I am a fan of the CrowPi from Elecrow. I have two of their first CrowPi

- Scott Hanselman

This is an interesting blog post on How to SSH into WSL2 on Windows 10 from an external machine. Rea

- Scott Hanselman

Cool blog post eh? Good title, right? DO NOT DO THE INSTRUCTIONS IN THIS POST until you have read th

- Scott Hanselman

I got a great question emailed to me today. And while I could find the answer and email them back, I

- Scott Hanselman

I've blogged before about Developing on Docker with the new and improved Visual Studio Containe

Meta