Deleting all the records in a table by Mistake using ADO.NET

Home » Advice for New Developers » C# » Deleting all the records in a table by Mistake using ADO.NET
Your Journey Starts Here on a blackboard

I was writing some ADO.NET data access code the other day and something stirred in the memory banks about a similar disaster to what I’m talking about in this post that happened years ago. I couldn’t remember exactly the circumstances of the original disaster but it prompted me to warn my team about it.

Consider the following code:

Can you spot the mistake?

If I told you that this mistake will result in all the records in the table being deleted and you look again, can you spot it?

Can you spot the mistake in this code?

The problem is the MyKey = MyKey or @MyKey = @MyKey should read MyKey = @MyKey. It just struck me that if you make a single character typo when writing this code, the end result would be to delete all the records in the table. In development shops that develop on shared test or live databases (one of my customers does, despite my continued protests), this can easily lead to disaster.

I’d be interested to know how many people spotted it on first read, especially if you weren’t previously aware of this type of thing. Our brains tend to read what we expect to see, rather than what’s actually there, for example repeating a word in a sentence isn’t always obvious for the same reason.

About Phil

I have been working as a software developer since 1983. This blog could have been called "From Fortran 77, C and Cobol to C# in 20 (not so) easy years", but it doesn't sound quite right somehow. Besides I'm talking about what's happened since 2003, not before!

Leave a Reply

Your email address will not be published.


You may use these HTML tags and attributes: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <cite> <code class="" title="" data-url=""> <del datetime=""> <em> <i> <q cite=""> <s> <strike> <strong> <pre class="" title="" data-url=""> <span class="" title="" data-url="">




Top Posts & Pages

Categories

Recent Posts

Recent Comments

Archives

Blogroll

  • Mike Cohn's Blog
  • Scott Hanselman's Blog
- mike@mountaingoatsoftware.com

Too often, agile teams are expected to finish everything every iteration. This expectation is harmfu [...]

- mike@mountaingoatsoftware.com

When a product backlog becomes too big, it hinders agility. Discover four steps your team can take t [...]

- mike@mountaingoatsoftware.com

Pervasive myths about agile get in the way of success. It’s time to bust six of those myths. [...]

- mike@mountaingoatsoftware.com

Agile teams strive to finish work in the same iteration in which its begun. Here’s why that is so im [...]

- mike@mountaingoatsoftware.com

I wrote 25 blog posts during 2018. In case you missed some of them, here are the most popular. [...]

- Scott Hanselman

My Xbox user name is Glucose for a reason. This is a passion project of mine. You've likely see [...]

- Scott Hanselman

I've been really enjoying my Xbox lately (when the family is asleep) as well as some fun Retrog [...]

- Scott Hanselman

So you've been asked to parse some dates, except the years are two digit years. For example, da [...]

- Scott Hanselman

I've been working on a little idea where I'd have an app (maybe a mobile app with Xamarin [...]

- Scott Hanselman

"EditorConfig helps maintain consistent coding styles for multiple developers working on the sa [...]

Meta