Deleting all the records in a table by Mistake using ADO.NET

Home » Advice for New Developers » C# » Deleting all the records in a table by Mistake using ADO.NET
Your Journey Starts Here on a blackboard

I was writing some ADO.NET data access code the other day and something stirred in the memory banks about a similar disaster to what I’m talking about in this post that happened years ago. I couldn’t remember exactly the circumstances of the original disaster but it prompted me to warn my team about it.

Consider the following code:

Can you spot the mistake?

If I told you that this mistake will result in all the records in the table being deleted and you look again, can you spot it?

Can you spot the mistake in this code?

The problem is the MyKey = MyKey or @MyKey = @MyKey should read MyKey = @MyKey. It just struck me that if you make a single character typo when writing this code, the end result would be to delete all the records in the table. In development shops that develop on shared test or live databases (one of my customers does, despite my continued protests), this can easily lead to disaster.

I’d be interested to know how many people spotted it on first read, especially if you weren’t previously aware of this type of thing. Our brains tend to read what we expect to see, rather than what’s actually there, for example repeating a word in a sentence isn’t always obvious for the same reason.

About Phil

I have been working as a software developer since 1983. This blog could have been called "From Fortran 77, C and Cobol to C# in 20 (not so) easy years", but it doesn't sound quite right somehow. Besides I'm talking about what's happened since 2003, not before!

Leave a Reply

Your email address will not be published.


You may use these HTML tags and attributes: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <cite> <code class="" title="" data-url=""> <del datetime=""> <em> <i> <q cite=""> <s> <strike> <strong> <pre class="" title="" data-url=""> <span class="" title="" data-url="">




Top Posts & Pages

Categories

Recent Posts

Recent Comments

Archives

Blogroll

  • Mike Cohn's Blog
  • Scott Hanselman's Blog
- mike@mountaingoatsoftware.com

Certified Scrum Trainer Lance Dacy and I discuss some trends we’re noticing and ponder the future of [...]

- mike@mountaingoatsoftware.com

Teams often struggle to persuade their product owners to prioritize refactoring. This simple four-st [...]

- mike@mountaingoatsoftware.com

One of the benefits of being on a team is the friendships you can make with your teammates. Many of [...]

- mike@mountaingoatsoftware.com

I wrote 24 blog posts during 2019. In case you missed some of them, here are the most popular. [...]

- mike@mountaingoatsoftware.com

It’s coming on Christmas. That time of year when I drop hints to my family about gifts I’d like. [...]

- Scott Hanselman

I've written about WSL2 and it's glorious wonders many times. As its release (presumably) [...]

- Scott Hanselman

Four years ago I wrote how to BUILD (literally compile) Visual Studio Code for a Raspberry Pi ARM ma [...]

- Scott Hanselman

It's time. It's the feature complete release of the Windows Terminal. Stop reading, and go [...]

- Scott Hanselman

At Microsoft Ignite 2019, we were happy to announce that the "Try .NET global tool" added [...]

- Scott Hanselman

I've blogged before about ASP.NET Architect David Fowler's hidden gems in ASP.NET. His Git [...]

Meta