Deleting all the records in a table by Mistake using ADO.NET

Home » Advice for New Developers » C# » Deleting all the records in a table by Mistake using ADO.NET
Your Journey Starts Here on a blackboard

I was writing some ADO.NET data access code the other day and something stirred in the memory banks about a similar disaster to what I’m talking about in this post that happened years ago. I couldn’t remember exactly the circumstances of the original disaster but it prompted me to warn my team about it.

Consider the following code:

Can you spot the mistake?

If I told you that this mistake will result in all the records in the table being deleted and you look again, can you spot it?

Can you spot the mistake in this code?

The problem is the MyKey = MyKey or @MyKey = @MyKey should read MyKey = @MyKey. It just struck me that if you make a single character typo when writing this code, the end result would be to delete all the records in the table. In development shops that develop on shared test or live databases (one of my customers does, despite my continued protests), this can easily lead to disaster.

I’d be interested to know how many people spotted it on first read, especially if you weren’t previously aware of this type of thing. Our brains tend to read what we expect to see, rather than what’s actually there, for example repeating a word in a sentence isn’t always obvious for the same reason.

About Phil

I have been working as a software developer since 1983. This blog could have been called "From Fortran 77, C and Cobol to C# in 20 (not so) easy years", but it doesn't sound quite right somehow. Besides I'm talking about what's happened since 2003, not before!

Leave a Reply

Your email address will not be published.


You may use these HTML tags and attributes: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <cite> <code class="" title="" data-url=""> <del datetime=""> <em> <i> <q cite=""> <s> <strike> <strong> <pre class="" title="" data-url=""> <span class="" title="" data-url="">




Top Posts & Pages

Categories

Recent Posts

Recent Comments

Archives

Blogroll

  • Mike Cohn's Blog
  • Scott Hanselman's Blog
- mike@mountaingoatsoftware.com

Our virtual Certified Scrum courses aren’t tedious 16-hour Zoom snoozefests. This video shows what t [...]

- mike@mountaingoatsoftware.com

Time pressure improves productivity & quality…up to a point. Learn how short iterations and accu [...]

- mike@mountaingoatsoftware.com

Boring retrospectives or ones in which people are afraid to speak the truth are just two of the most [...]

- mike@mountaingoatsoftware.com

If you really want to speed up your team, sign up now for Scrum Prime and have everything delivered [...]

- Scott Hanselman

During the Microsoft Build keynote last week - that you can watch free online here - we snuck in a L [...]

- Scott Hanselman

I've been spending a lot of time with Docker lately. Docker Desktop on Windows is great and get [...]

- Scott Hanselman

I was offered a Surface Book 3 to use as a loaner over the the last 5 weeks. I did a short video tea [...]

- Scott Hanselman

Last year Microsoft rebooted PowerToys and it's open source and on GitHub. It's a few mont [...]

- Scott Hanselman

Microsoft Build 2020 is upon us, registration is open NOW. Stop reading this blog post and go regist [...]

Meta